liubao68 commented on a change in pull request #861: [SCB-612]delete useless
MicroserviceMetaManager
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#discussion_r208780448
##########
File path:
core/src/main/java/org/apache/servicecomb/core/definition/loader/SchemaListenerManager.java
##########
@@ -74,12 +71,22 @@ public void notifySchemaListener(List<SchemaMeta>
schemaMetaList) {
}
public SchemaMeta ensureFindSchemaMeta(String microserviceName, String
schemaId) {
- MicroserviceMeta microserviceMeta =
microserviceMetaManager.ensureFindValue(microserviceName);
+ if
(!RegistryUtils.getMicroservice().getServiceName().equals(microserviceName)) {
+ LOGGER.error("miroserviceName : {} is different from the default
microserviceName :{}",
Review comment:
This is an internally used class, will this logic happen? Or can we delete
the parameter microserviceName?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
