WillemJiang commented on a change in pull request #268: SCB-865 Implement 
reaction of the event in Alpha Server
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/268#discussion_r212770993
 
 

 ##########
 File path: 
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/tcc/OmegaCallbacksRegistry.java
 ##########
 @@ -32,6 +33,10 @@
 
   private final static Map<String, Map<String, OmegaCallback>> REGISTRY = new 
ConcurrentHashMap<>();
 
 Review comment:
   Please don't use the static Map as the registry, it could introduce lots of 
trouble here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to