cherrylzhao commented on a change in pull request #268: SCB-865 Implement
reaction of the event in Alpha Server
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/268#discussion_r212790342
##########
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/tcc/OmegaCallbacksRegistry.java
##########
@@ -50,9 +55,18 @@ public static void register(GrpcServiceConfig request,
StreamObserver<GrpcTccCoo
* @param serviceName service name
* @param instanceId instance id
* @return Grpc omega TCC callback
+ * @throws AlphaException trigger this exception while missing omega
callback by service name
*/
- public static OmegaCallback retrieve(String serviceName, String instanceId) {
- return REGISTRY.getOrDefault(serviceName, emptyMap()).get(instanceId);
+ public static OmegaCallback retrieve(String serviceName, String instanceId)
throws AlphaException {
Review comment:
in saga omegacallback is a singleton。this is the same with static
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
