WillemJiang commented on a change in pull request #270: [SCB-868] Add Kamon
metrics to Alpha Server
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/270#discussion_r212844002
##########
File path: alpha/pom.xml
##########
@@ -75,20 +72,42 @@
<dependencies>
<dependency>
<groupId>io.kamon</groupId>
- <artifactId>kamon-log-reporter_2.12</artifactId>
+ <artifactId>kamon-autoweave_2.11</artifactId>
+ <version>${kamon.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.aspectj</groupId>
+ <artifactId>aspectjweaver</artifactId>
</dependency>
<dependency>
<groupId>io.kamon</groupId>
- <artifactId>kamon-statsd_2.12</artifactId>
+ <artifactId>kamon-log-reporter_2.11</artifactId>
+ <version>${kamon.version}</version>
</dependency>
<dependency>
<groupId>io.kamon</groupId>
- <artifactId>kamon-autoweave_2.12</artifactId>
- <version>0.6.5</version>
+ <artifactId>kamon-statsd_2.11</artifactId>
+ <version>${kamon.version}</version>
</dependency>
<dependency>
- <groupId>org.aspectj</groupId>
- <artifactId>aspectjweaver</artifactId>
+ <groupId>com.typesafe.akka</groupId>
+ <artifactId>akka-actor_2.11</artifactId>
Review comment:
Current Alpha Server doesn't use Akka, why did you put these dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
