maheshrajus commented on a change in pull request #270: [SCB-868] Add Kamon 
metrics to Alpha Server
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/270#discussion_r212868840
 
 

 ##########
 File path: alpha/alpha-server/src/main/resources/application.conf
 ##########
 @@ -24,31 +24,37 @@ kamon {
   metric {
     filters {
       trace.includes = ["**"]
+      trace.excludes = []
       trace-segment.includes = ["**"]
       trace-segment.excludes = []
-      akka-actor.includes = []
-      akka-actor.excludes = ["**"]
-      akka-dispatcher.includes = []
-      akka-dispatcher.excludes = ["**"]
+      akka-actor.includes = ["**"]
+      akka-actor.excludes = []
+      akka-dispatcher.includes = ["**"]
+      akka-dispatcher.excludes = []
     }
   }
 
   show-aspectj-missing-warning = no
 
   modules {
     kamon-annotation {
-      auto-start = no
+      auto-start = yes
 
 Review comment:
   while running the alpha server I have to provide auto-start yes for kamon.  
I put here yes and forgot to revert. i will make by default "no" and when user 
required then they will pass argument "yes".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to