This is an automated email from the ASF dual-hosted git repository. liubao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git
commit 8be5c34b87716111a917908e532e1213e0b6ac3a Author: liubao <[email protected]> AuthorDate: Thu Aug 30 20:10:58 2018 +0800 [SCB-880]fix review comments --- .../servicecomb/common/rest/codec/param/QueryProcessorCreator.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/QueryProcessorCreator.java b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/QueryProcessorCreator.java index 7cd31d3..124e178 100644 --- a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/QueryProcessorCreator.java +++ b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/QueryProcessorCreator.java @@ -35,6 +35,9 @@ public class QueryProcessorCreator implements ParamValueProcessorCreator { public static final String PARAMTYPE = "query"; public static class QueryProcessor extends AbstractParamProcessor { + private boolean emptyAsNull = DynamicPropertyFactory.getInstance() + .getBooleanProperty("servicecomb.rest.parameter.query.emptyAsNull", false).get(); + public QueryProcessor(String paramPath, JavaType targetType, Object defaultValue) { super(paramPath, targetType, defaultValue); } @@ -47,8 +50,7 @@ public class QueryProcessorCreator implements ParamValueProcessorCreator { } else { value = request.getParameter(paramPath); // make some old systems happy - if (DynamicPropertyFactory.getInstance() - .getBooleanProperty("servicecomb.rest.parameter.query.emptyAsNull", false).get()) { + if (emptyAsNull) { if (StringUtils.isEmpty((String) value)) { value = null; }
