wujimin commented on a change in pull request #891: [SCB-887]aysnc servlet
timeout is too short and may block container pool when tasks are timeout
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/891#discussion_r214802094
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##########
@@ -142,6 +145,18 @@ protected void scheduleInvocation() {
});
}
+ private boolean isInQueueTimeout() {
+ Object timeout =
requestEx.getAttribute(RestConst.REST_REQUEST_IN_QUEUE_TIME);
Review comment:
1.direct use invocation.getStartTime()?
is's a nanotime.
2.when invoke from highway, need this logic also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
