WillemJiang commented on a change in pull request #314: [SCB-891] Add kamon
metrics to Omega client
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/314#discussion_r231755224
##########
File path:
omega/omega-transport/omega-transport-dubbo/src/main/java/org/apache/servicecomb/saga/omega/transport/dubbo/SagaDubboConsumerFilter.java
##########
@@ -36,10 +36,14 @@
import static
org.apache.servicecomb.saga.omega.context.OmegaContext.GLOBAL_TX_ID_KEY;
import static
org.apache.servicecomb.saga.omega.context.OmegaContext.LOCAL_TX_ID_KEY;
+import kamon.annotation.EnableKamon;
+import kamon.annotation.Trace;
+
/**
* add saga transaction id to dubbo invocation
*/
@Activate(group = {Constants.CONSUMER})
+@EnableKamon
Review comment:
As there is no much work on the transport level, we don't need to add the
tag here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services