wujimin commented on a change in pull request #987: [SCB-1017]add os cpu net info in the metrics with linux os URL: https://github.com/apache/servicecomb-java-chassis/pull/987#discussion_r233081553
########## File path: metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/DefaultLogPublisher.java ########## @@ -47,6 +53,8 @@ public static final String ENABLED = "servicecomb.metrics.publisher.defaultLog.enabled"; + public static final String METRICS_OS_ENABLED = "servicecomb.metrics.publisher.defaultLog.printOs.enabled"; Review comment: why need this flag? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
