wujimin commented on a change in pull request #1017: [SCB-1056] put provider
flow control logic in front
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1017#discussion_r238167366
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##########
@@ -150,6 +167,39 @@ protected void scheduleInvocation() {
});
}
+ private Holder<Boolean> checkQpsFlowControl(OperationMeta operationMeta) {
+ Holder<Boolean> qpsFlowControlReject = new Holder<>(false);
+ Handler providerQpsFlowControlHandler =
findQpsFlowControlHandler(operationMeta);
+ if (null != providerQpsFlowControlHandler) {
+ try {
+ providerQpsFlowControlHandler.handle(invocation, response -> {
+ qpsFlowControlReject.value = true;
+ produceProcessor = ProduceProcessorManager.JSON_PROCESSOR;
+ sendResponse(response);
+ });
+ } catch (Exception e) {
+ LOGGER.error("failed to execute ProviderQpsFlowControlHandler", e);
+ qpsFlowControlReject.value = true;
+ sendFailResponse(e);
+ }
+ }
+ return qpsFlowControlReject;
+ }
+
+ @VisibleForTesting
+ Handler findQpsFlowControlHandler(OperationMeta operationMeta) {
Review comment:
it's not a good idea to find each time.
we can init and save it in OperationMeta, and mark the new field to be
temporary， only for internal usage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
