zhfeng commented on issue #346: compensation method invoke before compensable 
method
URL: 
https://github.com/apache/servicecomb-saga/issues/346#issuecomment-443947008
 
 
   @WillemJiang I think the current Narayana LRA implements the timeout at the 
coordinate side.
   
   1. set a schedule to cancel the transaction when enlist the participant in 
[LRARecord](https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/model/LRARecord.java#L773).
   2. doEnd in the [LRA 
Transaction](https://github.com/jbosstm/narayana/blob/master/rts/lra/lra-coordinator/src/main/java/io/narayana/lra/coordinator/domain/model/Transaction.java#L709)
 when timeout happens.
   
   So it maybe has the similar situation that the compensate method could be 
invoked before the business is done. And I think it is not clear described at 
the [LRA spec 
timeout](https://github.com/eclipse/microprofile-lra/blob/master/spec/src/main/asciidoc/microprofile-lra-spec.adoc#timing-out-lras-and-compensators).
   
   I think we can bring this case to the [LRA 
issues](https://github.com/eclipse/microprofile-lra/issues).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to