wujimin commented on a change in pull request #1013:
[SCB-1047]microservice.yaml service_description.version support form…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1013#discussion_r238551769
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/version/Version.java
##########
@@ -74,34 +78,52 @@ private short parseNumber(String name, String allVersion,
String version) {
return value;
}
- public Version(short major, short minor, short patch) {
+ public Version(short major, short minor, short patch, short build) {
this.major = major;
this.minor = minor;
this.patch = patch;
+ this.build = build;
this.version = combineStringVersion();
this.numberVersion = combineVersion();
}
private String combineStringVersion() {
- return major + "." + minor + "." + patch;
+ StringBuilder stringBuilder = new StringBuilder();
Review comment:
performance same to add directly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
