wujimin commented on a change in pull request #1046: [SCB-1095]Timer task need
catch all throwable to protected from unexpected error
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1046#discussion_r244440773
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/registry/RemoteServiceRegistry.java
##########
@@ -53,8 +53,8 @@ public RemoteServiceRegistry(EventBus eventBus,
ServiceRegistryConfig serviceReg
public void init() {
super.init();
taskPool = new ScheduledThreadPoolExecutor(2,
- task -> new Thread(task, "Service Center Task"),
- (task, executor) -> LOGGER.warn("Too many pending tasks, reject " +
task.getClass().getName())
+ task -> new Thread(task, "Service Center Task " + task.toString()),
Review comment:
if two threads create triggered by the same task, the two thread will have
the same name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
