coolbeevip commented on a change in pull request #394: [SCB 1128] Omega discovers alpha service from eureka URL: https://github.com/apache/servicecomb-pack/pull/394#discussion_r250267692
########## File path: omega/omega-spring-cloud-starter/src/main/java/org/apache/servicecomb/pack/omega/spring/cloud/EnableOmegaSpringCloud.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.servicecomb.pack.omega.spring.cloud; + +import org.apache.servicecomb.pack.omega.context.OmegaContext; +import org.apache.servicecomb.pack.omega.transaction.spring.TransactionAspectConfig; +import org.springframework.context.annotation.Import; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +@Target(ElementType.TYPE) +@Retention(RetentionPolicy.RUNTIME) +@Import({OmegaSpringEurekaConfig.class, TransactionAspectConfig.class}) +/** + * Indicates create the OmegaContext and inject it into the interceptors + * to pass the transactions id across the application. + * @see OmegaContext + */ +public @interface EnableOmegaSpringCloud { Review comment: Maybe we can let SpringFactoriesLoader automatically configure OmegaSpringConfig through spring.factories, so @EnableOmega is not needed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
