cherrylzhao commented on a change in pull request #391: for SCB-1113 refactor
omega spring-boot starter bean.
URL: https://github.com/apache/servicecomb-pack/pull/391#discussion_r251202286
##########
File path:
omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/pack/omega/connector/grpc/saga/GrpcCompensateStreamObserver.java
##########
@@ -17,43 +17,46 @@
package org.apache.servicecomb.pack.omega.connector.grpc.saga;
+import io.grpc.stub.StreamObserver;
import java.lang.invoke.MethodHandles;
-
-import
org.apache.servicecomb.pack.omega.connector.grpc.core.LoadBalanceContext;
-import
org.apache.servicecomb.pack.omega.connector.grpc.core.ReconnectStreamObserver;
-import org.apache.servicecomb.pack.omega.transaction.MessageDeserializer;
-import org.apache.servicecomb.pack.omega.transaction.MessageHandler;
-import org.apache.servicecomb.pack.omega.transaction.MessageSender;
import org.apache.servicecomb.pack.contract.grpc.GrpcCompensateCommand;
+import
org.apache.servicecomb.pack.omega.connector.grpc.core.ErrorHandleEngineManager;
+import
org.apache.servicecomb.pack.omega.connector.grpc.core.StreamObserverManager;
+import org.apache.servicecomb.pack.omega.transaction.MessageDeserializer;
+import org.apache.servicecomb.pack.omega.transaction.MessageHandlerManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-class GrpcCompensateStreamObserver extends
ReconnectStreamObserver<GrpcCompensateCommand> {
Review comment:
I have refactor it, extract a GrpcOnErrorHandleEngine to handle it.
this pr is big, it is better to pull my fork branch to review it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
