wujimin commented on a change in pull request #1075: [SCB-359]Servicecomb
support latency statistic
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1075#discussion_r251425990
##########
File path:
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/PublishUtils.java
##########
@@ -33,7 +34,12 @@ private PublishUtils() {
public static PerfInfo createPerfInfo(MeasurementNode stageNode) {
PerfInfo perfInfo = new PerfInfo();
-
+ MeasurementNode timeInterval =
stageNode.findChild(StatisticsBucket.TIME_INTERVAL);
+ // latency buckets
+ if (timeInterval != null) {
+ perfInfo.initInterval(timeInterval);
Review comment:
latency bucket is not belongs to perfInfo, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services