WillemJiang commented on a change in pull request #403: [SCB-1130] Dynamically configure the master node base on master_lock … URL: https://github.com/apache/servicecomb-pack/pull/403#discussion_r252106464
########## File path: alpha/alpha-server/src/main/java/org/apache/servicecomb/pack/alpha/server/cluster/master/provider/jdbc/SpringMasterLockRepository.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.servicecomb.pack.alpha.server.cluster.master.provider.jdbc; + +import kamon.annotation.EnableKamon; +import kamon.annotation.Segment; +import org.apache.servicecomb.pack.alpha.server.cluster.master.provider.jdbc.jpa.MasterLock; +import org.apache.servicecomb.pack.alpha.server.cluster.master.provider.jdbc.jpa.MasterLockRepository; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; + +import java.lang.invoke.MethodHandles; +import java.util.Date; +import java.util.Optional; + +@EnableKamon +@ConditionalOnProperty(name = "alpha.cluster.master.enabled", havingValue = "true") +public class SpringMasterLockRepository implements MasterLockRepository { + + private static final Logger LOG = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + private final MasterLockEntityRepository electionRepo; + + SpringMasterLockRepository(MasterLockEntityRepository electionRepo) { + this.electionRepo = electionRepo; + } + + @Override + @Segment(name = "MasterLockInit", category = "application", library = "kamon") + public boolean initLock(MasterLock masterLock) { + try { + Optional<MasterLock> lock = this.findMasterLockByServiceName(masterLock.getServiceName()); + if (!lock.isPresent()) { + electionRepo.initLock(masterLock.getServiceName(), + masterLock.getExpireTime(), + masterLock.getLockedTime(), + masterLock.getInstanceId()); + return true; + } else { + return false; + } + } catch (Exception e) { + LOG.error("Init lock error",e); + return false; + } + } + + @Override + @Segment(name = "MasterUpdateLock", category = "application", library = "kamon") + public boolean updateLock(MasterLock masterLock) { + try { + int size = electionRepo.updateLock( + masterLock.getServiceName(), + new Date(), + masterLock.getExpireTime(), + masterLock.getInstanceId()); + return size > 0 ? true : false; + } catch (Exception e) { Review comment: We should log the exception for troubleshooting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
