little-cui commented on a change in pull request #532: Issues-531 add
registration and discovery for client
URL:
https://github.com/apache/servicecomb-service-center/pull/532#discussion_r256677641
##########
File path: pkg/client/sc/websocket.go
##########
@@ -0,0 +1,31 @@
+package sc
+
+import (
+ "context"
+ "net/http"
+ "net/url"
+
+ "github.com/apache/servicecomb-service-center/pkg/backoff"
+ "github.com/gorilla/websocket"
+)
+
+func (c *LBClient) WebsocketDial(ctx context.Context, api string, headers
http.Header) (conn *websocket.Conn, err error) {
+ err = backoff.DelayIn(c.Retries, func() (rerr error) {
Review comment:
the backoff isn't expected here, just use for loop to retry the next
endpoint as soon as possible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
