yhs0092 commented on issue #1096: [SCB-1148] Read transport configuration from model URL: https://github.com/apache/servicecomb-java-chassis/pull/1096#issuecomment-465843798 Hello. There seems pretty good about this PR. But I get some other doubts about our new config model mechanism. 1. Is the instance of `ConfigObjectFactory` reusable? Currently the instance of `ConfigObjectFactory` stores the information about the instance of `PriorityProperty` created by it. Although it's okay to reuse the `ConfigObjectFactory` instance, it still seems a little bit strange if the instance of `ConfigObjectFactory` is reused. If we don't want people create multiple different `PriorityProperty` instances by one `ConfigObjectFactory` instance, maybe we can make the `create` method `static`, so we can avoid exposing the `ConfigObjectFactory` instance outside. 2. Is the `PriorityProperty` instances created by `ConfigObjectFactory` garbage collected by JVM? There seems no reference to the instances of `PriorityProperty`. Will they be garbage collected by JVM unexpectly?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
