wujimin commented on issue #1096: [SCB-1148] Read transport configuration from model URL: https://github.com/apache/servicecomb-java-chassis/pull/1096#issuecomment-465850112 1. ConfigObjectFactory is not support reusable, Creating a configuration module is a small probability event, and create ConfigObjectFactory is very light, no need to reuse it 2. about GC - com.netflix.config.PropertyWrapper#prop is referenced by global variable com.netflix.config.DynamicProperty#ALL_PROPS - com.netflix.config.PropertyWrapper#prop is type of com.netflix.config.DynamicProperty, com.netflix.config.DynamicProperty#callbacks reference callback from org.apache.servicecomb.config.priority.PriorityProperty - so PriorityProperty will not be GC.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
