heyile commented on a change in pull request #1075: [SCB-359]Servicecomb
support latency statistic
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1075#discussion_r259172255
##########
File path:
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/publish/PublishUtils.java
##########
@@ -33,7 +34,12 @@ private PublishUtils() {
public static PerfInfo createPerfInfo(MeasurementNode stageNode) {
PerfInfo perfInfo = new PerfInfo();
-
+ MeasurementNode timeInterval =
stageNode.findChild(StatisticsBucket.TIME_INTERVAL);
+ // latency buckets
+ if (timeInterval != null) {
+ perfInfo.initInterval(timeInterval);
Review comment:
Yes. I move it to the class **OperationPerf**, as I thought that every
operation has it's own latency
```java
public class OperationPerf {
private String operation;
private Map<String, PerfInfo> stages = new HashMap<>();
private Map<String, BucketInfo> buckets = new HashMap<>();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
