yhs0092 commented on a change in pull request #1161: [SCB-1232] make
GroupExecutor configuration compatible to old version
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1161#discussion_r270669836
##########
File path:
core/src/main/java/org/apache/servicecomb/core/executor/GroupExecutor.java
##########
@@ -106,6 +108,11 @@ public void initConfig() {
LOGGER.info(
"executor group={}. per group settings, coreThreads={}, maxThreads={},
maxIdleInSecond={}, maxQueueSize={}.",
groupCount, coreThreads, maxThreads, maxIdleInSecond, maxQueueSize);
+ LOGGER.info("JDK standard thread pool rules:\n"
+ + "1.use core threads.\n"
+ + "2.if all core threads are busy, then queue the request.\n"
+ + "3.if queue is full, then create new thread util reach the limit of
max threads.\n"
+ + "4.if queue is full, and threads count is max, then reject the
request.");
Review comment:
Do we change the stratege to create new thread first until the limit of max
threads is reached. And then queue the requests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
