coolbeevip commented on a change in pull request #446: fix mysql master_lock 
table schema wrong default value
URL: https://github.com/apache/servicecomb-pack/pull/446#discussion_r271557554
 
 

 ##########
 File path: alpha/alpha-server/src/main/resources/schema-mysql.sql
 ##########
 @@ -116,8 +116,8 @@ CREATE TABLE IF NOT EXISTS tcc_tx_event (
 
 CREATE TABLE IF NOT EXISTS master_lock (
   serviceName varchar(36) not NULL,
-  expireTime timestamp(3) not NULL,
-  lockedTime timestamp(3) not NULL,
+  expireTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP,
 
 Review comment:
   I have no problem testing in my local, it may be that your MySQL has set 
NO_ZEROR_DATE, you can check the following through the following command line
   
   ```bash
   show variables like 'sql_mode'
   ```
   Of course, I agree with this modification.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to