fengbaicanhe commented on a change in pull request #454: fix when
server.port=0, health check fail and also fix lose consul metadata, such as
'secure=false'
URL: https://github.com/apache/servicecomb-pack/pull/454#discussion_r277151320
##########
File path:
alpha/alpha-spring-cloud-starter-consul/src/main/java/org/apache/servicecomb/pack/alpha/server/discovery/consul/AlphaConsulAutoConfiguration.java
##########
@@ -114,7 +114,11 @@ public void
listenInstanceRegisteredEvent(InstanceRegisteredEvent instanceRegist
NewService newservice = new NewService();
newservice.setName(service.getServiceName());
newservice.setId(service.getServiceId());
- List<String> tags = consulDiscoveryProperties.getTags();
+ newservice.setAddress(service.getAddress());
Review comment:
~~I think so, the IP address is no need to change~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
