chanjarster opened a new pull request #486: [SCB-1335] Upgrade docker-compose file to 3.0 URL: https://github.com/apache/servicecomb-pack/pull/486 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- Upgrade demo's docker-compose files from version 2.1 to 3.0. Please notice that conditional `depends_on` which is add in 2.1 [\[1\]][1] is removed from 3.0 [\[2\]][2]. So I change the following like below: ```yaml depends_on: database: condition: service_healthy ``` to like this: ```yaml depends_on: - database ``` I tested the modified docker-compose file on my machine, that change also works except that there are some retry log like this: ```txt 2019-06-30 02:45:56.059 ERROR 1 --- [ault-executor-2] o.a.s.p.o.c.g.c.ReconnectStreamObserver : Failed to process grpc coordinate command. stacks... 2019-06-30 02:45:56.291 INFO 1 --- [pool-2-thread-1] .a.s.p.o.c.g.c.PushBackReconnectRunnable : Retry connecting to alpha at alpha-server.servicecomb.io:8080 2019-06-30 02:45:56.333 ERROR 1 --- [pool-2-thread-1] .a.s.p.o.c.g.c.PushBackReconnectRunnable : Failed to reconnect to alpha at alpha-server.servicecomb.io:8080 stacks... 2019-06-30 02:46:02.359 INFO 1 --- [pool-2-thread-1] .a.s.p.o.c.g.c.PushBackReconnectRunnable : Retry connecting to alpha at alpha-server.servicecomb.io:8080 2019-06-30 02:46:02.527 INFO 1 --- [pool-2-thread-1] .a.s.p.o.c.g.c.PushBackReconnectRunnable : Retry connecting to alpha at alpha-server.servicecomb.io:8080 is successful ``` [1]: https://docs.docker.com/compose/compose-file/compose-file-v2/#depends_on [2]: https://docs.docker.com/compose/compose-file/#depends_on
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
