This is an automated email from the ASF dual-hosted git repository. ningjiang pushed a commit to branch SCB-1321-cleanup in repository https://gitbox.apache.org/repos/asf/servicecomb-pack.git
commit 4c3c2c8f94828d1cfeb99a8e32a1e4a854ca166e Author: Willem Jiang <[email protected]> AuthorDate: Fri Jul 12 11:24:52 2019 +0800 SCB-1321 Added some TODO work which we can address later --- .../org/apache/servicecomb/pack/alpha/fsm/sink/SagaActorEventSender.java | 1 + .../pack/alpha/fsm/spring/integration/akka/SagaDataExtension.java | 1 + 2 files changed, 2 insertions(+) diff --git a/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/sink/SagaActorEventSender.java b/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/sink/SagaActorEventSender.java index cdc0828..ec38251 100644 --- a/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/sink/SagaActorEventSender.java +++ b/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/sink/SagaActorEventSender.java @@ -57,6 +57,7 @@ public class SagaActorEventSender implements ActorEventSink { } else { ActorSelection actorSelection = system .actorSelection("/user/" + event.getGlobalTxId()); + //TODO We should leverage the async API that actor provides to send out the message final Future<ActorRef> actorRefFuture = actorSelection.resolveOne(lookupTimeout); final ActorRef saga = Await.result(actorRefFuture, lookupTimeout.duration()); saga.tell(event, ActorRef.noSender()); diff --git a/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/spring/integration/akka/SagaDataExtension.java b/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/spring/integration/akka/SagaDataExtension.java index ae8d43d..7266c54 100644 --- a/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/spring/integration/akka/SagaDataExtension.java +++ b/alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/spring/integration/akka/SagaDataExtension.java @@ -31,6 +31,7 @@ import org.slf4j.LoggerFactory; public class SagaDataExtension extends AbstractExtensionId<SagaDataExt> { private static final Logger LOG = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); public static final SagaDataExtension SAGA_DATA_EXTENSION_PROVIDER = new SagaDataExtension(); + //TODO We could use test profile the enable this kind feature public static boolean autoCleanSagaDataMap = true; // Only for Test @Override
