WillemJiang commented on a change in pull request #9: SCB-1383 support toolkit
maven plugin commands that generating code
URL: https://github.com/apache/servicecomb-toolkit/pull/9#discussion_r307957597
##########
File path:
contractgen/src/test/java/org/apache/servicecomb/toolkit/contractgen/DefaultContractsGeneratorTest.java
##########
@@ -85,7 +86,11 @@ public void testGenerate()
DefaultContractsGenerator defaultContractsGenerator = new
DefaultContractsGenerator();
defaultContractsGenerator.configure(config);
- assertTrue(defaultContractsGenerator.generate());
+ try {
+ defaultContractsGenerator.generate();
+ } catch (RuntimeException e) {
+ fail();
Review comment:
It's better to add some information which case failure in the fail method.
It's could save us lot of time to find out the CI build error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
