liubao68 commented on a change in pull request #1283: [SCB-1407] Add new field
when print provideCache log
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1283#discussion_r309067299
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceRegisterTask.java
##########
@@ -68,6 +68,10 @@ protected boolean doRegister() {
microserviceInstance.getHealthCheck().setTimes(serviceRegistryConfig.getResendHeartBeatTimes());
String instanceId =
srClient.registerMicroserviceInstance(microserviceInstance);
+ MicroserviceInstance temIns =
srClient.findServiceInstance(microserviceInstance.getServiceId(),instanceId);
+ if(temIns!=null){
+ microserviceInstance.setTimestamp(temIns.getTimestamp());
Review comment:
Does service-center already add timestamp property and which version？ And if
it is neccessary to set timestamp information for the service itself (may be do
not need set this property, or we'd better to keep itself reference from
service center, not set a single property)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
