tianxiaoliang commented on a change in pull request #23: add 
GetHistoryByLabelID interface with unit test, Register history's UrlPatterns to 
chassis
URL: https://github.com/apache/servicecomb-kie/pull/23#discussion_r309628011
 
 

 ##########
 File path: pkg/model/mongodb_doc.go
 ##########
 @@ -45,8 +45,8 @@ type KVDoc struct {
 type LabelRevisionDoc struct {
        ID       primitive.ObjectID `json:"_id,omitempty" bson:"_id,omitempty"`
        LabelID  string             `json:"label_id,omitempty"  
bson:"label_id,omitempty"`
-       Labels   map[string]string  `json:"labels,omitempty"` //redundant
-       Domain   string             `json:"domain,omitempty"` //redundant
-       KVs      []*KVDoc           `json:"data,omitempty"`   // save states of 
this revision
+       Labels   map[string]string  `json:"labels,omitempty"`
+       Domain   string             `json:"domain,omitempty" bson:"-"`
 
 Review comment:
   do not ignore bson, ignore json

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to