coolbeevip opened a new pull request #529: [SCB-1423] Use the AtomInteger counter instead of ConcurrentLinkedQueue… URL: https://github.com/apache/servicecomb-pack/pull/529 ….size() AlphaIntegrationTest occasionally has an error on CI ```bash org.apache.servicecomb.pack.alpha.server.AlphaIntegrationTest doNotCompensateDuplicateTxOnFailure(org.apache.servicecomb.pack.alpha.server.AlphaIntegrationTest) Time elapsed: 1.356 sec <<< FAILURE! java.lang.AssertionError: Expected: iterable containing [<globalTxId: "1007c961-d2d1-49f5-a6e7-a92d90175107" localTxId: "59f2b19d-5dcd-4fa3-a596-8ce1a0bb3f09" parentTxId: "b6f44b80-8bd8-41d9-95ac-ab39d8c9fef3" compensationMethod: "method b" payloads: "service b" >, <globalTxId: "1007c961-d2d1-49f5-a6e7-a92d90175107" localTxId: "6e09819a-9bf4-4adc-b035-b13fa9028bc8" parentTxId: "3ecafe89-e1de-4a82-bef3-247265174bac" compensationMethod: "method a" payloads: "service a" >] but: Not matched: <globalTxId: "1007c961-d2d1-49f5-a6e7-a92d90175107" localTxId: "6e09819a-9bf4-4adc-b035-b13fa9028bc8" parentTxId: "3ecafe89-e1de-4a82-bef3-247265174bac" compensationMethod: "method a" payloads: "service a" > at org.apache.servicecomb.pack.alpha.server.AlphaIntegrationTest.doNotCompensateDuplicateTxOnFailure(AlphaIntegrationTest.java:276) ``` I think because of the non-thread-safe size method of ConcurrentLinkedQueue
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
