MabinGo commented on a change in pull request #13: SCB-1422 optimize classmaker
URL: https://github.com/apache/servicecomb-toolkit/pull/13#discussion_r311025016
##########
File path:
common/src/main/java/org/apache/servicecomb/toolkit/common/ClassMaker.java
##########
@@ -17,24 +17,33 @@
package org.apache.servicecomb.toolkit.common;
+import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
+import java.io.InputStreamReader;
import java.util.concurrent.TimeoutException;
-import org.apache.commons.io.IOUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class ClassMaker {
public static void compile(String projectPath) throws IOException,
TimeoutException, InterruptedException {
Runtime runtime = Runtime.getRuntime();
- Process exec = runtime.exec("mvn clean package -f " + projectPath);
+ String mvnCommand =
+ "mvn clean package -f " + projectPath;
Review comment:
assignment statement could be moved to same line here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
