kakulisen commented on a change in pull request #14: Support for configuring 
the toolkit maven plugin in the parent pom
URL: https://github.com/apache/servicecomb-toolkit/pull/14#discussion_r312304628
 
 

 ##########
 File path: 
codegen/src/test/java/org/apache/servicecomb/toolkit/codegen/GeneratorTest.java
 ##########
 @@ -86,5 +90,13 @@ public void testGetCodeGeneratorInstanse() {
     CodeGenerator unknownCodeGenerator = 
GeneratorFactory.getGenerator(CodeGenerator.class, "unknown");
     Assert.assertNull(unknownCodeGenerator);
   }
+
+  @Test
+  public void externalConfigGenerator() {
 
 Review comment:
   Thank you for reminding me, I will modify it in the next pr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to