coolbeevip commented on a change in pull request #534: SCB-1418 Alpha Event Kafka Channel Plugin URL: https://github.com/apache/servicecomb-pack/pull/534#discussion_r313677812
########## File path: alpha/alpha-fsm-channel-kafka/src/main/java/org/apache/servicecomb/pack/alpha/fsm/channel/kafka/KafkaMessagePublisher.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.servicecomb.pack.alpha.fsm.channel.kafka; + +import org.apache.servicecomb.pack.alpha.core.fsm.channel.MessagePublisher; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.kafka.core.KafkaTemplate; +import org.springframework.kafka.support.SendResult; +import org.springframework.util.concurrent.ListenableFuture; +import org.springframework.util.concurrent.ListenableFutureCallback; + +public class KafkaMessagePublisher implements MessagePublisher { + + private static final Logger logger = LoggerFactory.getLogger(KafkaMessagePublisher.class); + + private String topic; + private KafkaTemplate<String, Object> kafkaTemplate; + + public KafkaMessagePublisher(String topic, KafkaTemplate<String, Object> kafkaTemplate) { + this.topic = topic; + this.kafkaTemplate = kafkaTemplate; + } + + @Override + public void publish(Object data) { + if(logger.isDebugEnabled()){ + logger.debug("send message [{}] to [{}]", data, topic); + } + ListenableFuture<SendResult<String, Object>> listenableFuture = kafkaTemplate.send(topic, data); + + listenableFuture.addCallback(new ListenableFutureCallback<SendResult<String, Object>>() { + @Override + public void onFailure(Throwable throwable) { + + if(logger.isDebugEnabled()){ Review comment: I think we need to use synchronous sending, so as to avoid data loss when the process crashes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
