jeho0815 commented on a change in pull request #1295: [SCB-1431] set all 
dependency versions as properties
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1295#discussion_r313730253
 
 

 ##########
 File path: java-chassis-dependencies/springboot2/pom.xml
 ##########
 @@ -31,12 +31,16 @@
   <packaging>pom</packaging>
 
   <properties>
-    <spring.boot.version>2.1.2.RELEASE</spring.boot.version>
+    <!-- Dependency versions -->
+    <spring-boot.version>2.1.2.RELEASE</spring-boot.version>
 
 Review comment:
   2.1.3.RELEASE is better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to