liubao68 commented on a change in pull request #1351: [SCB-1523] Stopping retrying another server when no server available URL: https://github.com/apache/servicecomb-java-chassis/pull/1351#discussion_r335281508
########## File path: handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java ########## @@ -98,6 +98,9 @@ public Server chooseServer(Object key) { boolean isRetry = null != lastServer; for (int i = 0; i < COUNT; i++) { Server s = delegate.chooseServer((Invocation) key); + if (s == null) { + break; + } Review comment: unneccessary null check ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services