WillemJiang commented on a change in pull request #46: upgrade go chassis, eliminate cross dependency URL: https://github.com/apache/servicecomb-kie/pull/46#discussion_r336716907
########## File path: .gitignore ########## @@ -22,4 +22,3 @@ etc/data/ etc/ssl/ tmp/ glide.lock -go.sum Review comment: Why do you remove the this file from .gitignore. It's generated, do we need to keep track of it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
