alec-z commented on a change in pull request #45: add dependency licenses and
better some docs
URL: https://github.com/apache/servicecomb-kie/pull/45#discussion_r336864715
##########
File path: build/build_binary.sh
##########
@@ -82,7 +82,8 @@ EOM
}
writeConfig
-cp ${PROJECT_DIR}/LICENSE ${PROJECT_DIR}/NOTICE ${release_dir}
+cp ${PROJECT_DIR}/licenses/LICENSE ${PROJECT_DIR}/licenses/NOTICE
${release_dir}
+cp -r ${PROJECT_DIR}/licenses ${release_dir}
Review comment:
@WillemJiang Do you mean that we just need to keep the `cp -r
${PROJECT_DIR}/licenses ${release_dir}`?
This is the build_binary.sh. I checked the servicecomb-mesher binary
package, which has a LICENSE file and a licenses directory in the root
directory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
