WillemJiang commented on a change in pull request #45: add dependency licenses
and better some docs
URL: https://github.com/apache/servicecomb-kie/pull/45#discussion_r336879004
##########
File path: build/build_binary.sh
##########
@@ -82,7 +82,8 @@ EOM
}
writeConfig
-cp ${PROJECT_DIR}/LICENSE ${PROJECT_DIR}/NOTICE ${release_dir}
+cp ${PROJECT_DIR}/licenses/LICENSE ${PROJECT_DIR}/licenses/NOTICE
${release_dir}
+cp -r ${PROJECT_DIR}/licenses ${release_dir}
Review comment:
yes, we just need to keep the LICENSE and NOTICE file in the root directory
of the artifact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
