coolbeevip commented on a change in pull request #576: [SCB-1532] Redis
configuration is invalid
URL: https://github.com/apache/servicecomb-pack/pull/576#discussion_r337343587
##########
File path:
alpha/alpha-fsm/src/main/java/org/apache/servicecomb/pack/alpha/fsm/spring/integration/akka/AkkaConfigPropertyAdapter.java
##########
@@ -58,7 +59,18 @@
if (LOG.isTraceEnabled()) {
LOG.trace("Adding property {}={}" + key, value);
}
+
propertyMap.put(key, value);
+
+ if(name.startsWith(REDIS_NAME) &&
!propertyMap.containsKey(name)){
+ String readJournalKey =
("akka-persistence-redis.read-journal.redis.").concat(name.substring(REDIS_NAME.length()));
+ String journalKey =
("akka-persistence-redis.journal.redis.").concat(name.substring(REDIS_NAME.length()));
Review comment:
> why do we need to set up 3 configuration key with one value?
It's OK, akka-persistence-redis contain three components, journal, snapshot,
read-journal, their Redis configuration is the same.
https://github.com/safety-data/akka-persistence-redis/blob/master/src/main/resources/reference.conf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
