surechen commented on a change in pull request #50: SCB-1558 support query
history by key and fix wrong API doc
URL: https://github.com/apache/servicecomb-kie/pull/50#discussion_r341958689
##########
File path: server/resource/v1/history_resource.go
##########
@@ -33,16 +33,17 @@ import (
type HistoryResource struct {
}
-//GetRevisionsByLabelID search key only by label
-func (r *HistoryResource) GetRevisionsByLabelID(context *restful.Context) {
+//GetRevisions search key only by label
+func (r *HistoryResource) GetRevisions(context *restful.Context) {
var err error
labelID := context.ReadPathParameter("label_id")
if labelID == "" {
openlogging.Debug("label id is null")
WriteErrResponse(context, http.StatusForbidden, "label_id must
not be empty", common.ContentTypeText)
return
}
- revisions, err :=
service.HistoryService.GetHistoryByLabelID(context.Ctx, labelID)
Review comment:
Are there some condition parameters will be added in querying history
resources later？For example time spans.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
