WillemJiang commented on a change in pull request #591: SCB-1585 Optimize the
Netty server thread model to split bossEventLoo…
URL: https://github.com/apache/servicecomb-pack/pull/591#discussion_r345102764
##########
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/pack/alpha/server/GrpcStartable.java
##########
@@ -63,15 +64,21 @@ public GrpcStartable(GrpcServerConfig serverConfig,
EventBus eventBus, BindableS
if(unusedPort.isPresent()){
if (serverConfig.isSslEnable()){
serverBuilder = NettyServerBuilder.forAddress(
- new InetSocketAddress(serverConfig.getHost(),
unusedPort.getAsInt()));
+ new InetSocketAddress(serverConfig.getHost(),
unusedPort.getAsInt()))
Review comment:
I think it could be better to provide a method here to create ServerBuilder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
