WillemJiang commented on a change in pull request #593: [SCB-1593] Use Netty
native transport improve performance
URL: https://github.com/apache/servicecomb-pack/pull/593#discussion_r346725326
##########
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/pack/alpha/server/GrpcStartable.java
##########
@@ -202,4 +208,55 @@ private OptionalInt findUnusedPort(GrpcServerConfig
serverConfig) throws IOExcep
throw error[0];
}
}
+
+ /**
+ * https://netty.io/wiki/native-transports.html
+ *
+ * RHEL/CentOS/Fedora:
+ * sudo yum install autoconf automake libtool make tar \
+ * glibc-devel libaio-devel \
+ * libgcc.i686 glibc-devel.i686
+ * Debian/Ubuntu:
+ * sudo apt-get install autoconf automake libtool make tar \
+ * gcc-multilib libaio-dev
+ *
+ * brew install autoconf automake libtool
+ * */
+ private Class<? extends ServerChannel> selectorServerChannel() {
+ Class<? extends ServerChannel> channel = NioServerSocketChannel.class;
+ if (serverConfig.isNettyTransport()) {
+ if (OSInfo.isLinux()) {
Review comment:
It's better to add some Info log to tell user which kind of
ServerSocketChannel that Alpha choices.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
