liubao68 commented on a change in pull request #1400: [SCB-1407] Add gray release feature URL: https://github.com/apache/servicecomb-java-chassis/pull/1400#discussion_r348346533
########## File path: handlers/handler-router/src/main/java/org/apache/servicecomb/router/constom/CanaryInvokeFilter.java ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.servicecomb.router.constom; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.netflix.config.DynamicStringProperty; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; + +import org.apache.servicecomb.common.rest.filter.HttpServerFilter; +import org.apache.servicecomb.core.Invocation; +import org.apache.servicecomb.core.definition.OperationMeta; +import org.apache.servicecomb.foundation.common.utils.JsonUtils; +import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx; +import org.apache.servicecomb.foundation.vertx.http.HttpServletResponseEx; +import org.apache.servicecomb.swagger.invocation.Response; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.util.CollectionUtils; +import org.springframework.util.StringUtils; +import org.yaml.snakeyaml.Yaml; + +import com.netflix.config.DynamicPropertyFactory; + +import io.vertx.core.json.Json; + +public class CanaryInvokeFilter implements HttpServerFilter { + + private static final Logger LOGGER = LoggerFactory.getLogger(CanaryInvokeFilter.class); + + private static final String PASS_HEADER = "servicecomb.router.header"; + + private static List<String> allHeader = new ArrayList<>(); + + @Override + public int getOrder() { + return -90; + } + + @Override + public boolean enabled() { + return false; + } + + @Override + public boolean needCacheRequest(OperationMeta operationMeta) { + return false; + } + + /** + * 透传Header需要在这里实现， 因为无法预知调用链上的服务匹配所需要header, 提供两种模式 1.取到全量的header并放到context中， 2.从配置中解析并读取 + * + * @param invocation + * @param httpServletRequestEx + * @return + */ + @Override + public Response afterReceiveRequest(Invocation invocation, + HttpServletRequestEx httpServletRequestEx) { + loadHeaders(); + if (invocation.getContext("canary_context") != null && !CollectionUtils.isEmpty(allHeader)) { + Map<String, String> headerMap = getHeaderMap(httpServletRequestEx); + try { + invocation.addContext("canary_context", JsonUtils.OBJ_MAPPER.writeValueAsString(headerMap)); + } catch (JsonProcessingException e) { + LOGGER.error("canary context serialization failed"); + e.printStackTrace(); + } + } + return null; + } + + /** + * 读配置文件Header + */ + private void loadHeaders() { + DynamicStringProperty headerStr = DynamicPropertyFactory.getInstance() + .getStringProperty(PASS_HEADER, null, () -> { + allHeader = null; + DynamicStringProperty temHeader = DynamicPropertyFactory.getInstance() + .getStringProperty(PASS_HEADER, null); + Yaml yaml = new Yaml(); + allHeader = yaml.load(temHeader.get()); + }); + try { + if (allHeader != null) { Review comment: allHeader is inialized an emtpy list. Do you mean empty? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
