liubao68 commented on issue #1401: [SCB-1610] add updateInstanceStatus to 
ServiceRegistryClient.java
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/1401#issuecomment-556804448
 
 
   > > I create a issue to track this and updated this title. Can you do the 
following ?
   > > 
   > > 1. format the code using /etc foler code template
   > > 2. rebase and push again to help better merge the PR (This can help 
mantain all commits or we have to do a merge).
   > 
   > 我没有理解到你的意思 是说代码没有格式化么?还是说要做什么其他操作?
   
   是的,少量代码没有格式化,建议适用项目提供的模板格式化一下。 
第二个问题是指提交PR的分支可能不是基于master拉的,或者中间隔了几个commit,虽然也可以通过merge的方式合并,但是会丢失commit信息,可以进行一下rebase,保证可以在合入的时候,保留commit信息。
 
   
![image](https://user-images.githubusercontent.com/29354209/69293228-359c4f80-0c43-11ea-820d-4af4b773b235.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to