WillemJiang commented on a change in pull request #609: WIP [SCB-1627] Omega 
side CallbackContext send the compensation result event to Alpha
URL: https://github.com/apache/servicecomb-pack/pull/609#discussion_r352325381
 
 

 ##########
 File path: 
alpha/alpha-core/src/main/java/org/apache/servicecomb/pack/alpha/core/CompositeOmegaCallback.java
 ##########
 @@ -54,6 +56,11 @@ public void compensate(TxEvent event) {
 
     try {
       omegaCallback.compensate(event);
+    } catch (CompensateConnectException e) {
 
 Review comment:
   I think we just need to check the CompensateAskFailedException here.
   , as the other exception catch part just moves the callback connection.
    I doubt CompensateAskFailedException is a typo, the right one should be 
CompensateAckFailedException.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to