coolbeevip commented on a change in pull request #609: WIP [SCB-1627] Omega
side CallbackContext send the compensation result event to Alpha
URL: https://github.com/apache/servicecomb-pack/pull/609#discussion_r352448187
##########
File path:
alpha/alpha-core/src/main/java/org/apache/servicecomb/pack/alpha/core/CompositeOmegaCallback.java
##########
@@ -54,6 +56,11 @@ public void compensate(TxEvent event) {
try {
omegaCallback.compensate(event);
+ } catch (CompensateConnectException e) {
Review comment:
Yes, I will rename CompensateAskFailedException to
CompensateAckFailedException.
Because CallbackContext does not throw an exception, when the connection is
closed we need to throw a CompensateConnectException.
In addition, CompensateConnectException and CompensateAckFailedException
have different compensation failure strategies.
- CompensateConnectException: Immediately call another Omega instance
- CompensateAckFailedException: Retry until the max compRetries is reached
before calling another Omega instance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
