tianxiaoliang commented on a change in pull request #71: SCB-1723 support
pagination in kie apis
URL: https://github.com/apache/servicecomb-kie/pull/71#discussion_r367818524
##########
File path: server/service/service.go
##########
@@ -41,15 +41,15 @@ var (
type KV interface {
//below 3 methods is usually for admin console
CreateOrUpdate(ctx context.Context, kv *model.KVDoc) (*model.KVDoc,
error)
- List(ctx context.Context, domain, project string, limit, offset int,
options ...FindOption) (*model.KVResponse, error)
+ List(ctx context.Context, domain, project string, limit, offset int64,
options ...FindOption) (*model.KVResponse, error)
Delete(ctx context.Context, kvID string, domain, project string) error
//FindKV is usually for service to pull configs
- FindKV(ctx context.Context, domain, project string, options
...FindOption) ([]*model.KVResponse, error)
+ FindKV(ctx context.Context, domain, project string, limit, offset
int64, options ...FindOption) ([]*model.KVResponse, error)
Review comment:
param还是有点长了，把limit 和offset放到functonal options里面把
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
