codecov-io commented on issue #635: [SCB-1788] [Syncer] Change moduleServer 
interface definition to simplify code
URL: 
https://github.com/apache/servicecomb-service-center/pull/635#issuecomment-591532154
 
 
   # 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=h1)
 Report
   > Merging 
[#635](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc)
 will **increase** coverage by `0.88%`.
   > The diff coverage is `88.31%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #635      +/-   ##
   =========================================
   + Coverage   57.12%     58%   +0.88%     
   =========================================
     Files         207     212       +5     
     Lines       16062   16208     +146     
   =========================================
   + Hits         9175    9402     +227     
   + Misses       6220    6142      -78     
   + Partials      667     664       -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[syncer/pkg/utils/atomic\_bool.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hdG9taWNfYm9vbC5nbw==)
 | `100% <100%> (ø)` | |
   | 
[syncer/task/idle/idle.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svaWRsZS9pZGxlLmdv)
 | `100% <100%> (ø)` | |
   | 
[syncer/task/task.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGFzay5nbw==)
 | `100% <100%> (ø)` | |
   | 
[syncer/task/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGlja2VyL3RpY2tlci5nbw==)
 | `100% <100%> (ø)` | |
   | 
[syncer/serf/agent.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvYWdlbnQuZ28=)
 | `43.95% <44.44%> (+4.16%)` | :arrow_up: |
   | 
[syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv)
 | `56.25% <57.14%> (-7.39%)` | :arrow_down: |
   | 
[syncer/config/verify.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy92ZXJpZnkuZ28=)
 | `81.9% <81.9%> (ø)` | |
   | 
[syncer/config/merge.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9tZXJnZS5nbw==)
 | `92.53% <92.53%> (ø)` | |
   | 
[syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=)
 | `86.27% <93.33%> (+39.69%)` | :arrow_up: |
   | 
[server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==)
 | `78.94% <0%> (-9.29%)` | :arrow_down: |
   | ... and [23 
more](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=footer).
 Last update 
[85dc71b...b3576f7](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to