liubao68 commented on a change in pull request #1664: [SCB-1822]fix problems
when using multiple consumer interface for one…
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1664#discussion_r398984065
##########
File path:
providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/Invoker.java
##########
@@ -162,6 +162,8 @@ public Object invoke(Object proxy, Method method, Object[]
args) {
SwaggerConsumerOperation consumerOperation =
pojoConsumerOperationMeta.getSwaggerConsumerOperation();
OperationMeta operationMeta = pojoConsumerOperationMeta.getOperationMeta();
+ // operation meta is static data based on swagger, while consumer
operation based on invoker, have interface info
+ operationMeta.setSwaggerConsumerOperation(consumerOperation);
Review comment:
From invocation, can only get OperationMeta. Current code put all invocation
data(e.g. response type) to OperationMeta. This is not good, need refactor in
future, but this PR not working on this refactoring, because it is related to
some other parts besides this issue. I create an
[issue](https://issues.apache.org/jira/browse/SCB-1830) and refactoring the
code later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
