liubao68 commented on a change in pull request #1688: [SCB-1828] Support
@JSONVIEW
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1688#discussion_r404481112
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/definition/RestOperationMeta.java
##########
@@ -257,31 +263,71 @@ private void addParam(RestParam param) {
paramMap.put(param.getParamName(), param);
}
+ public ProduceProcessor findProduceProcessor(String type, String serialView)
{
Review comment:
Maybe this code can be better. Because:
ProduceProcessor can be constructed at initialization, and will not change
when excepting requests. So only `findProduceProcessor(String type)` can expose
to the callers. `findProduceProcessor(String type, String serialView)` is not
needed. And `ensureFindProduceProcessor` do not need to processing annotations
for each request, but process once when initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
